Make covers' redstone work slightly better - #5177
Open
jurrejelle wants to merge 3 commits into
Open
Conversation
jurrejelle
added
type: bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Before, covers into blocks didn't work. Now they work slightly better, but still not great. They now emit both weak and strong redstone.
Implementation Details
it seems the redstone code (e.g. the getOutputDirectSignal) is being called both server and clientside,but the client side doesn't have the data so ti returns 0. I am under the impression that redstone is server only so that shouldn't affect things? and regardless if I put e.g. a redstone lamp after the repeater it also doesn't update/work
AI Usage
Opus 4.8 did most of the impl, I reviewed it.
Outcome
Before:
After:
