Make the live RotorHazard transport a default feature#349
Merged
Conversation
A default-off product transport was a footgun that fired twice in one day: a plain-cargo-build dev deploy shipped a Director that could never leave "Configured" (lost test session), and — worse — the desktop release crate (src-tauri) depends on gridfpv-app without naming `live`, so the SHIPPED artifact had no RotorHazard adapter at all. `live` is now in gridfpv-app's default features: every plain build, the desktop artifact, and dev deploys all carry the real transport. The openssl-vendored TLS compile is a cache-warm one-time cost. The slim Mock/sim-only OpenSSL-free build remains available via --no-default-features. Fixed two latent lints/matches in the live-gated code that default CI had never compiled (a doc-indent lint in the RH transport; rh_live's Event match missing RoundFieldDrawn). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the user's question while testing ("why is live gated? I feel like it should be in the default build") — investigation confirmed it's worse than a dev footgun: the desktop release crate depends on gridfpv-app without naming
live, so the shipped artifact had no RotorHazard adapter at all (a v1 release blocker — the product's whole job is talking to real timers).default = ["live"]on gridfpv-app: plain builds, dev deploys, and the desktop artifact all carry the real transport now.--no-default-featuresstill yields the slim OpenSSL-free Mock/sim build, and the Docker-bound live test classes are unchanged.rh_live's exhaustive Event match missing the newRoundFieldDrawn).cargo xtask cigreen (now compiling the live code by default — permanent lint coverage for the transport), contract 90/90.🤖 Generated with Claude Code