Marshaling: void/adjust synthetic passes (re-detection commit fix)#351
Merged
Conversation
…Inserted/LapSplit)
The RH save-then-pull catch-up path records recovered laps as LapInserted;
the corrected-pass fold fully supports voiding / re-timing them ('void the
void'), but require_pass_target accepted only raw Event::Pass — so exactly
the laps most likely to need marshaling were un-voidable, and a re-detection
commit on such a heat bounced with 'log offset N is not a detected pass'
(hit live, Qualifying Heat 9 / Krait). The validator now accepts the same
lap-gate pass set the fold does (raw Pass | LapInserted | LapSplit),
matching the sibling ThrowOutLap/SplitLap validator.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-testing find: committing a re-detection bounced with
log offset 5022 is not a detected pass.The RotorHazard adapter's save-then-pull catch-up records recovered laps as synthetic
LapInsertedpasses. The corrected-pass fold fully supports voiding/re-timing them ("void the void" target resolution), andThrowOutLap/SplitLapalready accept them — butrequire_pass_target(VoidDetection/AdjustLap) accepted only rawEvent::Pass. Net effect: exactly the laps most likely to need marshaling (the ones the live stream missed) were the ones the marshal couldn't touch, and any re-detection diff containing one failed to commit.Validator widened to the fold's pass set (raw
Pass|LapInserted|LapSplit); doc table updated; regression test drives both commands against aLapInsertedtarget throughapply_command.Verified live: the exact failing command now acks ok and the lap folds out. 37 suites green, clippy/fmt clean.
🤖 Generated with Claude Code