fix[next]: Explicitly import fbuiltin members in gt4py.next#2484
Open
DropD wants to merge 1 commit intoGridTools:mainfrom
Open
fix[next]: Explicitly import fbuiltin members in gt4py.next#2484DropD wants to merge 1 commit intoGridTools:mainfrom
fbuiltin members in gt4py.next#2484DropD wants to merge 1 commit intoGridTools:mainfrom
Conversation
Radically reduce the amount of required type ignores in client code which uses the `from gt4py import next as gtx` pattern.
egparedes
reviewed
Feb 18, 2026
Contributor
egparedes
left a comment
egparedes
left a comment
There was a problem hiding this comment.
Thanks for the PR. I just have a comment and a question
| ) | ||
| from .program_processors.runners.roundtrip import default as itir_python | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
I think we should add some kind of automated test to make sure we do not forget to reexport content form fbuiltins if we modified that file. Just as an example draft:
Suggested change
| assert not (missing := ({*fbuiltins.__all__} - globals().keys())), f"Missing reexports of gt4py.next builtins: {missing}" |
| # mypy can not see through runtime logic in "fbuiltins" | ||
| disable_error_code = ["attr-defined"] | ||
| module = 'gt4py.next' | ||
|
|
Contributor
There was a problem hiding this comment.
Question: why is this needed? What error is mypy generating here?
Contributor
Author
There was a problem hiding this comment.
one of these for each member:
src/gt4py/next/__init__.py:42:1: error: Module "gt4py.next.ffront.fbuiltins" does not explicitly export attribute "uint32" [attr-defined]
I theorize it is because to determine which attributes are actually in fbuiltins.__all__, mypy would have to execute code. We are generating and concatenating lists, no idea why we do all of that dynamically at import time...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Radically reduce the amount of required type ignores in client code which uses the
from gt4py import next as gtxpattern.Requirements