fix[cartesian]: don't upcast arguments of power function#2489
Open
romanc wants to merge 1 commit intoGridTools:mainfrom
Open
fix[cartesian]: don't upcast arguments of power function#2489romanc wants to merge 1 commit intoGridTools:mainfrom
romanc wants to merge 1 commit intoGridTools:mainfrom
Conversation
Contributor
|
This is looking good to me. Should we move it in? |
Contributor
Author
Sure, feel free to go ahead. Then let's see next week if this helps with physics stability on MacOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@FlorianDeconinck / @twicki here's the branch/PR which adds an exception for casting exponent and base of the power function to the same type.
Background: This came up in physics validation where we noticed that the current rule set will translate the following stencil code
into
with the
debuganddace:cpu_kfirstbackends respectively.The PR attempts to avoid casting the exponent (
2) into a 32-bit float just because the base valuewueis aFloatField.Requirements
N/A