fix[cartesian]: MacOS & OpenMP: skip the multithreading#2491
Open
FlorianDeconinck wants to merge 3 commits intoGridTools:mainfrom
Open
fix[cartesian]: MacOS & OpenMP: skip the multithreading#2491FlorianDeconinck wants to merge 3 commits intoGridTools:mainfrom
FlorianDeconinck wants to merge 3 commits intoGridTools:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deactivate OpenMP when detecting MacOS (
Darwin) as the OS.The reason are simple
apple-clangdon't ship withopenmpby default and the way to acquire it is requiresbrewor other workaround we won't expect out of our users.In detail the PR:
omp_get_max_threadsfrom codegen on the glue code of stencil DaCe backends when all the computes are sequential (non MacOS related),StencilBuilderto centralize deactivation of OpenMP and turn it off when detectingDarwin(+ warning),openmpflags from the command line based on the above option.Requirements