Moved the Exit condition and back out condition into the while loop#5
Open
dmKronenberg wants to merge 1 commit intoGriffintaur:masterfrom
Open
Moved the Exit condition and back out condition into the while loop#5dmKronenberg wants to merge 1 commit intoGriffintaur:masterfrom
dmKronenberg wants to merge 1 commit intoGriffintaur:masterfrom
Conversation
Griffintaur
reviewed
Aug 10, 2017
|
|
||
| if articleNumber==99 : | ||
| sys.exit() | ||
| if articleNumber==66 : |
Owner
There was a problem hiding this comment.
It will not work as expected.
If the user enters 66 then it will ask a user to select another article but the intention of the user was to go to the main menu to select different news source.
Small fix needed something on the lines of
if article no is 66 or 99 break from the immediate loop and then decide whether to exit or go back to the main menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added your suggestion in.