Change: Block food/drinks consumption instead of auto-unequipping helmet (FDDA Redone)#645
Open
Velosyped wants to merge 15 commits intoGrokitach:dev2from
Open
Change: Block food/drinks consumption instead of auto-unequipping helmet (FDDA Redone)#645Velosyped wants to merge 15 commits intoGrokitach:dev2from
Velosyped wants to merge 15 commits intoGrokitach:dev2from
Conversation
SaloEater's Remember HFE's Stove Slot short name to avoid cloning issues
Mods install index fix
Afterglow Ending Crash Fix - yaaargle correct index value
Crash fix for cig3 when thrown on the ground
Higher chance for mercs to have rifles
Coffee in the zone install update
Update FDDA consumption logic for helmets.
Add English localization
Added st_fdda_helmet_fix.xml in Windows-1251 encoding to ensure correct Cyrillic display in-game.
|
Do you smart enough? |
Owner
|
Please switch the branch to dev2 |
|
I manually installed this from discord and it works as advertised. With strict helmet mode checked, I must remove my headgear (with that very nice animation) before eating/drinking/smoking. I definitely prefer seeing the message than having the character remove it for me. Though without the fix it would just eat/drink/smoke despite strict mode being active. It does look like there are some unrelated changes in the diff though, I think dev2 needs to be merged to Velosyped's branch first. Thanks by the way for this fix ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: This PR changes the "Strict Helmet" mode behavior in liz_fdda_redone_consumables.script. The automatic helmet removal has been replaced with a requirement for the player to unequip the helmet themselves before consuming items.
Detailed Changes:
Strict Helmet Mode Logic Change: Refactored the "Strict Helmet" option in MCM.
Prevention instead of Automation: Removed the on_toggle_unequip sequence that automatically stripped the player's helmet. Now, the script simply blocks the animation and usage if a closed helmet is detected.
Player Requirement: To eat or drink, the player must now manually unequip their helmet first. If they don't, the action is cancelled and a warning is shown.
Targeted Items: This applies to food and drinks. Medical items are not affected.
Dynamic Localization: Added a warning message that switches between English and Russian based on the game's language:
English: "I need to remove face protection first"
Russian: "Сначала мне нужно снять защиту с лица"
Technical Implementation: Added st_fdda_helmet_fix.xml (ENG in UTF-8, RUS in Windows-1251).