feat: Add comprehensive unit tests for core services#106
Open
bbjiggy wants to merge 6 commits into
Open
Conversation
- Added unit tests for IdentityService with full CRUD coverage - Added unit tests for VerificationService including approve/reject flows - Added unit tests for AuthService covering authentication logic - All tests include proper mocking of dependencies - Tests cover both happy paths and error cases (NotFoundException) - Achieves high code coverage for critical business logic
|
@meshackyaro is attempting to deploy a commit to the Josie's projects Team on Vercel. A member of the Team first needs to authorize it. |
- Fixed formatting in access_control.rs - Fixed formatting in data_sharing.rs - Fixed formatting in identity_registry.rs - Fixed formatting in lib.rs - Fixed formatting in verification.rs - Ensures CI formatting checks pass
Resolved conflicts in Rust smart contracts: - Accepted upstream changes with improved error handling using Result types - Applied proper Rust formatting with cargo fmt - Maintained consistency with upstream code style - All conflicts resolved in access_control.rs, data_sharing.rs, identity_registry.rs, lib.rs, and verification.rs
- Changed tuple key from &(&owner, &document_hash) to (owner.clone(), document_hash.clone()) - Soroban storage requires owned values in tuple keys, not references - Fixes E0277 trait bound error for TryFromVal - All clippy checks now pass
- Added [features] section with testutils feature that enables soroban-sdk/testutils - Fixes CI test failure where cargo test --features testutils was failing - Allows CI to run tests with testutils feature enabled
- Updated soroban-sdk from 21.0.0 to 21.7.7 for consistency - Added panic = "abort" to release profile for WASM compatibility - Fixes E0152 duplicate lang item error (panic_impl) - WASM build now compiles successfully for wasm32-unknown-unknown target
Member
|
Kindly fix conflicts @bbjiggy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive unit tests for the core backend services to improve code quality and reliability.
Changes
IdentityService Tests: Complete test coverage for all CRUD operations
VerificationService Tests: Full verification workflow coverage
AuthService Tests: Authentication logic coverage
Testing Approach
Benefits
Test Statistics
How to Run Tests
Type of Change
Notes