Skip to content

Fix some PHPStan errors#319

Draft
jmsche wants to merge 3 commits into
Guikingone:mainfrom
jmsche:fix-some-phpstan-deprecations
Draft

Fix some PHPStan errors#319
jmsche wants to merge 3 commits into
Guikingone:mainfrom
jmsche:fix-some-phpstan-deprecations

Conversation

@jmsche

@jmsche jmsche commented Jun 19, 2023

Copy link
Copy Markdown
Contributor
Q A
PHP version? N/A
Bundle version? 0.10.2
Symfony version? N/A
New feature? no
Bug fix? kind of
Discussion? N/A

Fixing some PHPStan errors.

Not sure what's the best way to fix remaining DBAL (schema-related) & PHPUnit (withConsecutive() call) deprecations, so leaving them for now.

@Guikingone

Copy link
Copy Markdown
Owner

Hi @jmsche 👋🏻

As this PR update the dbal version, I think it could be a better idea to add it in 0.11 or 1.0 if that's good for you?

@jmsche jmsche marked this pull request as draft June 20, 2023 06:40
@jmsche

jmsche commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

Sure :) As the bundle is still in v0.x version, it may be okay to release it for next 0.x version.

Just converted the PR to draft, as I found a (long) way to fix the withConsecutive() calls :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants