Draft
Conversation
dpogue
commented
Apr 29, 2021
Hoikas
reviewed
Apr 29, 2021
|
|
||
| if layer_props.funky_type != "FunkyDist": | ||
| # Mention that values are angles | ||
| layout.label("Values should be viewing angles in degrees between 0 and 180.", icon="RESTRICT_VIEW_OFF") |
Member
There was a problem hiding this comment.
I think this should probably be a separate set of properties that display as angles in the UI. You could have another set of properties as your universal getters. IIRC angle float types in blender return in radians so the export math would be simpler.
korman/exporter/material.py
Outdated
Comment on lines
257
to
258
| funky_ramp = self.export_funky_slot(bo, bm, hsgmat, slot, idx) | ||
| if funky_ramp: |
Member
There was a problem hiding this comment.
Sigh, if we were on Python 3.8 this would be a good place to use the walrus...
| else: | ||
| buf[start:end] = [b for b in (255, 255, 255, int((x * y) * 255.9))] | ||
|
|
||
| mipmap.setRawImage(bytes(buf)) |
Member
There was a problem hiding this comment.
The C++ uses setImageData instead of setRawImage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Do