Detect duplicates in participant_id column#102
Open
HippocampusGirl wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds duplicate detection for the participant_id column in phenotype files and includes corresponding unit tests. The changes ensure data integrity by preventing duplicate participant IDs from being loaded into the workflow. Type annotations are also added to improve code clarity.
Changes:
- Added duplicate participant_id validation in
load_data_frame()function - Added type annotations for
agesandgendersnumpy arrays - Created comprehensive unit tests for the
load_data_frame()function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| wonkyconn/workflow.py | Added duplicate detection check for participant_id and type annotations for age/gender arrays |
| wonkyconn/tests/test_workflow.py | New test file with comprehensive tests for load_data_frame validation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 54.03% 53.65% -0.38%
==========================================
Files 26 27 +1
Lines 1414 1437 +23
==========================================
+ Hits 764 771 +7
- Misses 650 666 +16
🚀 New features to boost your workflow:
|
And add unit test
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
368f947 to
919d623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #101
And add unit test