fix(INTER_RASM): fix to runtime/retsig global variable#17
Open
Gab-San wants to merge 1 commit intoHEAPLab:masterfrom
Open
fix(INTER_RASM): fix to runtime/retsig global variable#17Gab-San wants to merge 1 commit intoHEAPLab:masterfrom
Gab-San wants to merge 1 commit intoHEAPLab:masterfrom
Conversation
Gab-San
force-pushed
the
INTER_RASM/fix_global_value
branch
from
3360d9d to
f2a8f3a
Compare
Contributor
Author
|
I have noticed that there are no tests for inter-rasm |
Collaborator
|
The fix is legit. The only thing is that I would create the global variables only if their search in the code fails. After this change I will merge it |
Gab-San
force-pushed
the
INTER_RASM/fix_global_value
branch
from
f2a8f3a to
1d8863e
Compare
There was a problem hiding this comment.
Pull request overview
Fixes initialization/availability of the runtime_sig and run_adj_sig globals used by the RASM LLVM pass when INTRA_FUNCTION_CFC == 1, addressing MartinaStarone#17.
Changes:
- Removes unused standard library includes in
passes/RASM.cpp. - Updates
RASM::run()logic intended to locate (and, if missing, create) theruntime_sig/run_adj_sigglobals before instrumentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Sorry, I didn't know Copilot had this feature. I am gonna fix the issues immediately |
Gab-San
force-pushed
the
INTER_RASM/fix_global_value
branch
2 times, most recently
from
1eb78e7 to
f60e499
Compare
Fix runtime and retsig global variables to be correctly initialized. Solve issue #17
Gab-San
force-pushed
the
INTER_RASM/fix_global_value
branch
from
f60e499 to
245f9a8
Compare
Contributor
Author
|
If the manual check does not suffice I will look more in depth into it. Tested manually against a test file (both with global declared and not declared) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix runtime and retsig global variables to be correctly initialized.
Solve issue MartinaStarone#17