dashboard: add "Edit Title" option for submissions without an attached INSPIRE ID by Copilot · Pull Request #961 · HEPData/hepdata

Copilot · 2026-03-31T18:12:16Z

…INSPIRE ID Agent-Logs-Url: https://github.com/HEPData/hepdata/sessions/32e73825-d444-4737-b992-19c670171d01 Co-authored-by: GraemeWatt <11544204+GraemeWatt@users.noreply.github.com>

Now just creates the client object once and logs it in initially.

Sets url to variable as it is reused

Now disables the submission button when the edit title input is empty on the dashboard. Error message is now displayed on input and not click for empty state.

Function was using incorrect tabs instead of two space indent

codecov · 2026-04-23T15:29:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.14%. Comparing base (51a18b0) to head (1615759).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
+ Coverage   86.09%   86.14%   +0.05%     
==========================================
  Files          59       59              
  Lines        5759     5782      +23     
==========================================
+ Hits         4958     4981      +23     
  Misses        801      801

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coveralls · 2026-04-23T15:30:06Z

Coverage Report for CI Build 25801350675

Coverage increased (+0.06%) to 86.147%

Details

Coverage increased (+0.06%) from the base build.
Patch coverage: No coverable lines changed in this PR.
18 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

18 previously-covered lines in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
modules/dashboard/views.py	18	82.12%

Coverage Stats


Relevant Lines:	5782
Covered Lines:	4981
Line Coverage:	86.15%
Coverage Strength:	0.86 hits per line

💛 - Coveralls

GraemeWatt

@ItIsJordan : thanks, looks good. I made a comment about the logic for displaying the "Please provide a title" message. It would be useful to extend the tests to cover the three missing lines in the new update_submission_title function. Please also update the branch from main.

…e-option Co-authored-by: GraemeWatt <11544204+GraemeWatt@users.noreply.github.com>

…sion_title Agent-Logs-Url: https://github.com/HEPData/hepdata/sessions/42217021-0160-48da-8c7c-8641439a6060 Co-authored-by: GraemeWatt <11544204+GraemeWatt@users.noreply.github.com>

Copilot · 2026-04-24T12:14:50Z

@ItIsJordan : thanks, looks good. I made a comment about the logic for displaying the "Please provide a title" message. It would be useful to extend the tests to cover the three missing lines in the...

Done in 9b70861 — fixed the JS logic bug and added the three missing test cases (submission is None → 404, no permissions → 403, record is None → 404). Also merged from main.

Copilot

Pull request overview

Adds a dashboard feature allowing coordinators/admins to edit the provisional title of submissions that do not yet have an attached INSPIRE ID.

Changes:

Added a new backend endpoint POST /dashboard/update_title/<recid> to persist a new submission title (with permission + INSPIRE checks).
Added an “Edit Title” button, modal widget, and dashboard JS to launch the modal and submit the update via AJAX.
Added tests for key error cases and the happy path.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`hepdata/modules/dashboard/views.py`	Adds the `update_submission_title` route that updates the record title.
`hepdata/modules/dashboard/templates/hepdata_dashboard/dashboard-submissions.html`	Adds an “Edit Title” button next to “Attach INSPIRE Record”.
`hepdata/modules/dashboard/templates/hepdata_dashboard/edit-title-widget.html`	Introduces the modal UI for editing and saving the title.
`hepdata/modules/dashboard/templates/hepdata_dashboard/dashboard.html`	Includes the new edit-title widget on the dashboard page.
`hepdata/modules/dashboard/assets/js/hepdata_dashboard.js`	Adds modal open/close logic, validation UI, and the AJAX POST to update the title.
`tests/dashboard_test.py`	Adds endpoint tests for success and various failure scenarios.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Needed for "Submissions Overview" to display updated title. * Extend test to check that title was updated in admin index.

GraemeWatt

I've accepted most of the Copilot review comments and also made a commit b00e68d to update the admin index when updating the title (needed by the "Submissions Overview").

* Sleep 1s after updating title before searching admin index. * Also check original title in admin index before updating it.

Add a comment and update variable. Moves unittest.mock inport to top.

Currently the edit title widget does not pass any error message received by the server. Updates this to happen.

ItIsJordan

Feedback in PR comments.

Initial plan

fb17ab8

Copilot AI assigned Copilot and GraemeWatt Mar 31, 2026

Copilot started work on behalf of GraemeWatt March 31, 2026 18:12 View session

Copilot AI linked an issue Mar 31, 2026 that may be closed by this pull request

dashboard: add an "Edit Title" option for submissions without an attached INSPIRE ID #562

Closed

dashboard: add Edit Title option for submissions without an attached …

6b9068a

…INSPIRE ID Agent-Logs-Url: https://github.com/HEPData/hepdata/sessions/32e73825-d444-4737-b992-19c670171d01 Co-authored-by: GraemeWatt <11544204+GraemeWatt@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add 'Edit Title' option for submissions without INSPIRE ID~~ dashboard: add "Edit Title" option for submissions without an attached INSPIRE ID Mar 31, 2026

Copilot AI requested a review from GraemeWatt March 31, 2026 18:27

Copilot finished work on behalf of GraemeWatt March 31, 2026 18:27

GraemeWatt requested review from ItIsJordan April 1, 2026 13:46

dashboard: change colour of "Edit Title" button

63dbbc3

GraemeWatt assigned ItIsJordan Apr 1, 2026

ItIsJordan added 4 commits April 23, 2026 11:34

Fix test_update_submission_title test login issue

b557920

Now just creates the client object once and logs it in initially.

Improve test_update_submission_title

02eb251

Sets url to variable as it is reused

Disable edit title input button when empty

5445e03

Now disables the submission button when the edit title input is empty on the dashboard. Error message is now displayed on input and not click for empty state.

Fix indentation in edit title save button onclick function

371e446

Function was using incorrect tabs instead of two space indent

GraemeWatt requested changes Apr 24, 2026

View reviewed changes

Comment thread hepdata/modules/dashboard/assets/js/hepdata_dashboard.js

Comment thread hepdata/modules/dashboard/views.py

Comment thread hepdata/modules/dashboard/views.py

Comment thread hepdata/modules/dashboard/views.py

Copilot started work on behalf of GraemeWatt April 24, 2026 12:04 View session

GraemeWatt unassigned Copilot Apr 24, 2026

Copilot AI and others added 2 commits April 24, 2026 12:12

Merge remote-tracking branch 'origin/main' into copilot/add-edit-titl…

874da0d

…e-option Co-authored-by: GraemeWatt <11544204+GraemeWatt@users.noreply.github.com>

Fix JS title error logic and add missing test cases for update_submis…

9b70861

…sion_title Agent-Logs-Url: https://github.com/HEPData/hepdata/sessions/42217021-0160-48da-8c7c-8641439a6060 Co-authored-by: GraemeWatt <11544204+GraemeWatt@users.noreply.github.com>

Copilot finished work on behalf of GraemeWatt April 24, 2026 12:16

Copilot AI requested a review from GraemeWatt April 24, 2026 12:16

GraemeWatt assigned Copilot Apr 24, 2026

GraemeWatt marked this pull request as ready for review April 24, 2026 12:53

Copilot AI review requested due to automatic review settings April 24, 2026 12:53

Copilot started reviewing on behalf of GraemeWatt April 24, 2026 12:54 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

GraemeWatt and others added 2 commits April 27, 2026 12:53

Apply suggestions from code review

ff0454c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

dashboard: update admin index when updating title

b00e68d

* Needed for "Submissions Overview" to display updated title. * Extend test to check that title was updated in admin index.

GraemeWatt approved these changes Apr 27, 2026

View reviewed changes

GraemeWatt and others added 6 commits April 27, 2026 17:32

tests: fix test_update_submission_title

a982d71

* Sleep 1s after updating title before searching admin index. * Also check original title in admin index before updating it.

Merge branch 'main' into copilot/add-edit-title-option

a25ca7b

Merge branch 'main' into copilot/add-edit-title-option

4880801

Minor improvements to test_update_submission_title

c93608c

Add a comment and update variable. Moves unittest.mock inport to top.

Allow update title error message to pass to edit title widget

b0d2cfe

Currently the edit title widget does not pass any error message received by the server. Updates this to happen.

Merge branch 'main' into copilot/add-edit-title-option

1615759

ItIsJordan approved these changes May 13, 2026

View reviewed changes

GraemeWatt merged commit 5145873 into main May 13, 2026
10 checks passed

GraemeWatt deleted the copilot/add-edit-title-option branch May 13, 2026 14:25

Conversation

Copilot AI commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coveralls commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 25801350675

Coverage increased (+0.06%) to 86.147%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

GraemeWatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GraemeWatt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ItIsJordan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Mar 31, 2026 •

edited

Loading

codecov Bot commented Apr 23, 2026 •

edited

Loading

coveralls commented Apr 23, 2026 •

edited

Loading