Add SimpleAnalysis analyses JSON#975
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 86.03% 86.09% +0.05%
==========================================
Files 59 59
Lines 5759 5759
==========================================
+ Hits 4955 4958 +3
+ Misses 804 801 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Coverage Report for CI Build 25790275312Coverage increased (+0.02%) to 86.057%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Marking as ready for review from @GraemeWatt because the SimpleAnalysis link was finalised. |
GraemeWatt
left a comment
There was a problem hiding this comment.
I temporarily commented out the Combine test in commit 0204d68 until the CMS JSON file is fixed so it doesn't block development. I'll merge now. Thanks for your contribution.
|
This PR is now deployed in production on hepdata.net and the new links have been added. A search |
|
I updated the SimpleAnalysis part of the HEPData submission docs to mention the new linking via the JSON file. |
Similar to #908, this PR adds usage of the analyses JSON interface for SimpleAnalysis. In some way, it is also an extension of #864 / #925: in that issue/ PR, support for searching for SimpleAnalysis codes directly attached to a record was added. However, not all records for which a SimpleAnalysis implementation is available have the code directly uploaded to HEPData. For some, the code is only available in the SimpleAnalysis repository.
SimpleAnalysis now exposes a JSON with all implementations so we can fill that gap - as done in this PR. According tests check whether we count the codes directly attached to records and the links we get from the JSON correctly.
Marking the PR as draft, though, until the final link pattern for SimpleAnalysis is decided (as discussed here) because it's checked in the test.