Skip to content

Fix: FontComboBox closes unexpectedly #6238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KSSJW wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: FontComboBox closes unexpectedly #6238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c43728
Fix: FontComboBox closes unexpectedly
KSSJW Jun 27, 2026
dc7f35b
Refactor: FontComboBox target node judge
KSSJW Jun 27, 2026
106d7c4
Refactor: FontComboBox safety
KSSJW Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/FontComboBox.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
import com.jfoenix.controls.JFXListCell;

import javafx.beans.binding.Bindings;
import javafx.scene.Node;
import javafx.scene.control.ListCell;
import javafx.scene.control.ListView;
import javafx.scene.control.skin.ComboBoxListViewSkin;
import javafx.scene.text.Font;

public final class FontComboBox extends JFXComboBox<String> {
Expand Down Expand Up @@ -61,5 +65,25 @@ public void updateItem(String item, boolean empty) {
setItems(observableList(Font.getFamilies()));
loaded = true;
});

skinProperty().addListener((obs, oldSkin, newSkin) -> {
if (!(newSkin instanceof ComboBoxListViewSkin<?> skin)) {
return;
}

skin.setHideOnClick(false);

if (skin.getPopupContent() instanceof ListView<?> listView) {
listView.addEventHandler(javafx.scene.input.MouseEvent.MOUSE_CLICKED, e -> {
Node target = e.getTarget() instanceof Node ? (Node) e.getTarget() : null;
while (target != null && !(target instanceof ListCell)) {
target = target.getParent();
}
if (target instanceof ListCell<?> cell && !cell.isEmpty()) {
hide();
}
});
}
});
}
}