Feature/icon resumed by HSavynetska · Pull Request #4 · HSavynetska/sdl_atf_test_scripts

HSavynetska · 2018-03-30T07:22:51Z

No description provided.

… logic

GetmanetsIrina · 2018-03-30T07:57:24Z

+-- Use case:TBD
+--
+-- Requirement summary:
+-- TBD


add new line, also in scripts below

GetmanetsIrina · 2018-03-30T07:58:09Z

+-- In case:
+-- 1) SDL, HMI are started.
+-- 2) Mobile app registers first time.
+-- SDL does: Successfully registers application and responds with result code "SUCCESS" and "iconResumed" = false" to mobile application.


Add new line after "SDL does:"

GetmanetsIrina · 2018-03-30T08:01:26Z

+---------------------------------------------------------------------------------------------------
+--[[ Required Shared libraries ]]
+local runner = require('user_modules/script_runner')
+local common = require('test_scripts/API/SetAppIcon/comSetApp')


please rename common From comSetApp to 'commonIconResumed'

GetmanetsIrina · 2018-03-30T08:02:57Z

+runner.Step("Start SDL, HMI, connect Mobile, start Session", common.start)
+
+runner.Title("Test")
+runner.Step("App registration with iconresumed = false", common.registerApp, { 1, false })


iconresumed -> iconResumed

GetmanetsIrina · 2018-03-30T08:04:17Z

+-- In case:
+-- 1) SDL, HMI are started.
+-- 2) Mobile application is registered and sets custom icon via sending PutFile and valid SetAppIcon request.
+-- 3) 3) Mobile app is re-registered.


GetmanetsIrina · 2018-04-02T11:20:34Z

+runner.Step("SetAppIcon", common.setAppIcon, { allParams } )
+runner.Step("Gets_INVALID_DATA", setAppIcon_INVALID_DATA, { false, 1 } )
+runner.Step("App unregistration", common.unregisterAppInterface, { 1 })
+runner.Step("App registration with iconresumed = false", common.registerApp, { 1, false, false })


update 'false, false' to 'false'

GetmanetsIrina · 2018-04-02T11:25:37Z

@@ -0,0 +1,67 @@
+---------------------------------------------------------------------------------------------------
+-- Proposal: https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0041-appicon-resumption.md


Is script duplicated with script above?

GetmanetsIrina · 2018-04-02T11:27:51Z

+end
+
+local function updatePTU(tbl)
+  tbl.policy_table.app_policies[config.application.registerAppInterfaceParams.appID]. ImageFieldName = { "appIcon" }


function is not complete and is not valid. Please update function to valid and correct. Update must remove permissions from SetAppIcon RPC .

GetmanetsIrina · 2018-04-02T11:28:10Z

@@ -0,0 +1,68 @@
+---------------------------------------------------------------------------------------------------
+-- Proposal: https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0041-appicon-resumption.md


as script below

GetmanetsIrina · 2018-04-02T11:28:38Z

+runner.testSettings.isSelfIncluded = false
+
+--[[ Test Configuration ]]
+runner.testSettings.isSelfIncluded = false


dboltovskyi · 2018-04-02T15:11:19Z

@@ -0,0 +1,110 @@
+---------------------------------------------------------------------------------------------------


@HSavynetska Why do we need 3 common modules? Or these are duplicates and need to be removed?

GetmanetsIrina · 2018-04-03T06:03:27Z

+  local mobSession = common.getMobileSession(pAppId)
+  local cid = mobSession:SendRPC("SetAppIcon", params.requestParams)
+  params.requestUiParams.appID = common.getHMIAppId()
+  EXPECT_HMICALL("UI.SetAppIcon", params.requestUiParams)


Here you expect tat message UI.SetAppIcon will be not received and create Do step for receiving. So ,what step is redundant?

GetmanetsIrina · 2018-04-03T06:03:46Z

+runner.Title("Test")
+runner.Step("App registration with iconresumed = true", common.registerApp, { 1, true })
+runner.Step("Upload icon file", common.putFile)
+runner.Step("SetAppIcon", common.setAppIcon, { allParams } )


remove success SetAppIcon

GetmanetsIrina · 2018-04-03T06:05:51Z

+--[[ @registerApp: register mobile application
+--! @parameters:
+--! pAppId - application number (1, 2, etc.)
+--! pIconResumed - Existence of apps icon at system


not existence, value for iconResumed parameter

GetmanetsIrina · 2018-04-03T06:06:07Z

+--! @parameters:
+--! pAppId - application number (1, 2, etc.)
+--! pIconResumed - Existence of apps icon at system
+--! @return: none


What about 3rd parameter?

GetmanetsIrina · 2018-04-03T06:08:17Z

+  end
+end
+
+function m.registerApp1(pAppId, pIconResumed, pReconnection)


Function duplicates registerApp

GetmanetsIrina · 2018-04-03T06:16:06Z

+end
+
+--Description: setAppIcon successfully
+  --paramsSend: Parameters will be sent to SDL


parameter has different name, please update.

GetmanetsIrina · 2018-04-03T06:16:45Z

+  mobSession:ExpectResponse(cid, { success = true, resultCode = "SUCCESS" })
+end
+
+function m.connectMobile()


remove useless function.

GetmanetsIrina · 2018-04-03T06:17:13Z

+function m.connectMobile()
+  test:connectMobile()
+end
+


add description for function as above

GetmanetsIrina · 2018-04-03T06:18:46Z

+    { syncFileName = pIcon })
+    EXPECT_HMINOTIFICATION("BasicCommunication.OnFileRemoved",
+      {
+      fileName = pIcon,


please update alignment

GetmanetsIrina · 2018-04-03T06:19:38Z

+      {
+      fileName = pIcon,
+      fileType = "GRAPHIC_PNG",
+      appID = 1 })


Do not understand - what is value for appID?

GetmanetsIrina · 2018-04-03T10:52:20Z

-- SDL does: 
-- 1) Successfully registers application.
+-- SDL does:
+-- 1) Successfully register application.


comment is also related to item 2,3,4

GetmanetsIrina · 2018-04-03T10:59:32Z

-  params.requestUiParams.appID = common.getHMIAppId()
-
+  local cid = mobSession:SendRPC("SetAppIcon", params)
  EXPECT_HMICALL("UI.SetAppIcon", params.requestUiParams)


Times(0) is required here

GetmanetsIrina · 2018-04-03T12:50:26Z

+-- 3) Mobile app is re-registered.
+-- SDL does:
+-- 1) Successfully register application.
+-- 2) Successful processes PutFile and SetAppIcon requests.


Successful process PutFile and SetAppIcon requests.

Respond with result code "SUCCESS" and "iconResumed" = true for RAI request.

Send to HMI OnAppRegistered notification "icon" and notify that apps icon exists.

GetmanetsIrina · 2018-04-03T12:51:23Z

+-- 3) Mobile application is unregistered.
+-- 4) Mobile app is re-registered.
+-- SDL does:
+-- 1) SDL respon with result code "SUCCESS" and "iconResumed" = true for RAI request.


Respond with result code "SUCCESS" and "iconResumed" = true for RAI request.

GetmanetsIrina · 2018-04-03T12:51:55Z

+runner.Step("Start SDL, HMI, connect Mobile, start Session", common.start)
+
+runner.Title("Test")
+runner.Step("App registration with iconResumed = true", common.registerAppWOPTU, { 1, false })


App registration with iconResumed = false

GetmanetsIrina · 2018-04-04T08:39:07Z

+-- 3) HMI is not respond to SetAppIcon request. Mobile App received response SetAppIcon(GENERIC_ERROR).
+-- 4) App is re-registered.
+-- SDL does:
+-- 1) Registers an app successfully, responds to RAI with result code "SUCCESS", "iconResumed" = false.


register, respond

GetmanetsIrina · 2018-04-04T08:40:41Z

+-- 3) Mobile App received response SetAppIcon(INVALID_DATA). Custom Icon is not set.
+-- 4) App is re-registered.
+-- SDL does:
+-- 1) Successfully registers application.


register, respond

GetmanetsIrina · 2018-04-04T08:41:10Z

+-- 4) Mobile app received response SetAppIcon(DISALLOWED)
+-- 5) Mobile app is re-registered.
+-- SDL does:
+-- 1) Registers an app successfully, responds to RAI with result code "SUCCESS", "iconResumed" = false.


register, respond

GetmanetsIrina · 2018-04-04T08:41:44Z

+-- 3) HMI responds with REJECTED resultCode to SetAppIcon request. Mobile App received response SetAppIcon(REJECTED).
+-- 4) App is re-registered.
+-- SDL does:
+-- 1) Registers an app successfully, responds to RAI with result code "SUCCESS", "iconResumed" = false.


update 'SDL does' according to script

GetmanetsIrina · 2018-04-04T08:43:04Z

+runner.Step("Upload icon file1", common.putFile)
+runner.Step("SetAppIcon1", common.setAppIcon, { allParams } )
+
+runner.Step("Upload icon file2", common.putFile)


uploads the same icon and sets also the same icon

* Fix disconnect instability * Fix Ignition Off instability * Fix instability in Policy scripts

HSavynetska requested review from GetmanetsIrina and dboltovskyi March 30, 2018 07:23

HSavynetska force-pushed the feature/icon_Resumed branch 3 times, most recently from 6082697 to 437ff56 Compare April 2, 2018 12:09

dboltovskyi added 17 commits April 2, 2018 15:16

Add test sets for Release 4.5 issues

847e82f

Fix cast to string in common module for Resumption

68917c3

Fix obtaining of MAC address and Device Id

b5c4e5a

Fix file names

0269b1b

Add additional expectation for PTU sequence

8abed62

Create common module for security

5aa6337

Correct parameter name

b5c496c

Refactoring test scripts for Security

6bb27e5

Remove unused code

d60b4ec

Decrease priority of internal ATF expectations

8f5cb5d

Change SDL protocol version to 2

c79a94e

Stabilize scripts

69ef8f2

Correct expectation function and common module for certificates

fe60436

Remove defaulting of 2nd version of SDL protocol

c98e17a

Update Policy scripts regarding Device Id and Device Name calculation…

fe3ec30

… logic

Update Policy scripts regarding URL changes in PreloadedPT

3a90459

Add new functions to Utils module

8961ca7

HSavynetska force-pushed the feature/icon_Resumed branch from 437ff56 to a1e8c20 Compare April 2, 2018 12:20

GetmanetsIrina requested changes Apr 2, 2018

View reviewed changes

dboltovskyi requested changes Apr 2, 2018

View reviewed changes

GetmanetsIrina requested changes Apr 3, 2018

View reviewed changes

GetmanetsIrina requested changes Apr 4, 2018

View reviewed changes

HSavynetska force-pushed the feature/icon_Resumed branch from 5f4391f to 3092077 Compare April 4, 2018 11:41

HSavynetska added 2 commits April 4, 2018 14:49

Created common SetAppIcon

f714f5a

Changed commonSetAppIcon

a4732ab

HSavynetska and others added 11 commits April 4, 2018 14:49

Update common

cabca8b

Test script for the first checklist item

f9eb4da

Test_scripts 15.03.2018

6d57d79

Test_scripts_for_iconResumed

ae62474

Tests_iconResumed

91ebeb8

modified_Tests_iconResumed

24df261

Update test_scripts 02.04.2018

264ac57

Delete test_scripts

78ea31c

Update test_script №4 02.04.2018

693d043

Modified test_script_for_iconResumed

92b4e77

Made changes to the test script for icon_Resumed

6664e45

HSavynetska force-pushed the feature/icon_Resumed branch from 3092077 to 6664e45 Compare April 4, 2018 11:50

HSavynetska force-pushed the develop branch from e18545b to 65b591c Compare May 21, 2018 09:36

HSavynetska pushed a commit that referenced this pull request Jun 2, 2020

Improve stability of scripts #4 (smartdevicelink#2415)

29976d3

* Fix disconnect instability * Fix Ignition Off instability * Fix instability in Policy scripts

		@@ -0,0 +1,67 @@
		---------------------------------------------------------------------------------------------------
		-- Proposal: https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0041-appicon-resumption.md

		@@ -0,0 +1,68 @@
		---------------------------------------------------------------------------------------------------
		-- Proposal: https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0041-appicon-resumption.md

		@@ -0,0 +1,110 @@
		---------------------------------------------------------------------------------------------------

Conversation

HSavynetska commented Mar 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants