Conversation
14 tasks
Contributor
🏷️ Automatic Labeling SummaryThis PR has been automatically labeled based on the files changed and PR metadata. Applied Labels: size-xs Label Categories
For more information, see |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
… tests - Extract chrome/types.ts (interfaces: ChromeOptions, SiteChrome, BreadcrumbItem) - Extract chrome/helpers.ts (depth, renderHreflangBlock, fallbackAlternateHref) - Extract chrome/head.ts (renderChromeHead — SEO, OG, JSON-LD, hreflang) - Extract chrome/header.ts (buildHeaderHtml — nav, CTA, breadcrumb, hero) - Extract chrome/footer.ts (buildFooterHtml — columns, badges, scripts) - Rewrite chrome.ts as thin façade delegating to sub-modules - Fix `any` type in chrome JSON-LD findIndex (replaced with typed JsonLdNode) - Add 59 comprehensive tests in chrome-decomposition.test.ts covering: - Sub-module isolation (no circular deps) - HTML5 structural correctness - WCAG 2.1 AA accessibility (skip-link, ARIA, roles) - RTL language handling (Arabic, Hebrew) - hreflang for all 14 languages - JSON-LD injection and XSS prevention - SEO meta tags (OG, Twitter Cards) - Language switcher (14 languages) - Hero banner control - Pagination rel links - All 430 existing tests pass (zero regressions) Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/e1a3c2db-9238-4874-8434-5932e8e4da99 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
github-actions
Bot
added
testing
…dence tests - 8 tests for NewsArticle JSON-LD (required fields, author, publisher, provenance) - 6 tests for BreadcrumbList JSON-LD (positions, validation, error handling) - 4 tests for SpeakableSpecification WebPage JSON-LD - 9 tests for markdown pipeline independence from chrome (GFM, sanitization) - 3 tests for markdown security boundaries (XSS prevention) - 3 tests for mermaid preprocessor - Total: 33 new tests, all passing Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/e1a3c2db-9238-4874-8434-5932e8e4da99 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Copilot
AI
changed the title
[WIP] Refactor architecture and improve test coverage for rendering pipeline
feat: decompose chrome.ts into bounded-context sub-modules with comprehensive tests
May 6, 2026
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Comment on lines
+15
to
+17
| import type { Language } from '../../types/language.js'; | ||
| import { LANGUAGE_META, escapeHtml } from '../../generate-sitemap-html.js'; | ||
| import { BASE_URL, GITHUB_BLOB, LANGUAGES } from '../constants.js'; |
| * @license Apache-2.0 | ||
| */ | ||
|
|
||
| import type { Language } from '../../types/language.js'; |
| */ | ||
|
|
||
| import type { Language } from '../../types/language.js'; | ||
| import { LANGUAGE_META } from '../../generate-sitemap-html.js'; |
| readonly publishedIso?: string; | ||
| /** ISO-8601 date for `article:modified_time` / `og:updated_time`. */ | ||
| readonly modifiedIso?: string; | ||
| /** JSON-LD blob(s) appended inside `<head>`. Already-stringified objects. */ |
Comment on lines
+150
to
+154
| ${hreflangHtml} | ||
|
|
||
| <link rel="sitemap" type="application/xml" href="/sitemap.xml"> | ||
| <link rel="alternate" type="application/rss+xml" title="Riksdagsmonitor news (${escapeHtml(meta.nativeName)})" href="${opts.rssHref ?? '/rss.xml'}"> | ||
| ${pagerLinksHtml} |
Member
|
@copilot apply changes based on the comments in this thread |
- Remove unused Language/BASE_URL imports from header.ts
- Remove unused Language import from footer.ts
- Switch all chrome sub-modules from generate-sitemap-html.js (CLI side effects)
to scripts/sitemap-html/index.js (pure exports: LANGUAGE_META, escapeHtml)
- Fix jsonLd docstring in types.ts: clarify plain objects are expected (not
pre-serialised strings) since head renderer calls JSON.stringify internally
- Align RSS href default in head.ts with footer: use per-language /rss_{lang}.xml
for non-English (was always /rss.xml regardless of lang)
Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/971dbb8c-8f37-4274-962a-887ce3c118a1
Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Applied all 5 review changes in 98f7a45:
All 105 affected tests still pass, ESLint clean. |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Member
|
@copilot failing checks |
TypeScript type-check (scripts) was failing with TS6196 because SiteChrome was imported but never referenced in the test file. Agent-Logs-Url: https://github.com/Hack23/riksdagsmonitor/sessions/df174842-32f7-4138-acaa-8f15122fb240 Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Contributor
Author
Fixed in aec5636. The TypeScript type-check (scripts) was failing with TS6196 because |
Contributor
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chrome.ts(742 lines) into focused sub-modules (head, header, footer, helpers, types) each ≤200 linesanytype in chrome.ts (replaced with typedJsonLdNodeinterface)Language/BASE_URLimports fromheader.tsandfooter.tsgenerate-sitemap-html.js(CLI side-effects) withsitemap-html/index.jsin all chrome sub-modulesjsonLddocstring: clarify plain objects required (not pre-serialised strings)/rss_{lang}.xmlSiteChromeimport inchrome-decomposition.test.ts(caused TS6196 type-check failure)