Correct for different line separators#1
Open
CodeSpoof wants to merge 1 commit intoHackerPoet:mainfrom
Open
Conversation
Since UNIX-Systems only use LF for a line-break and Windows uses CRLF, std::getline handles the separator differently depending on the platform. This causes problems with wordlists formatted in Windows-style line-breaks when using them on UNIX-like systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since UNIX-Systems only use
LFfor a line-break and Windows usesCRLF,std::getlinehandles the separator differently depending on the platform. This causes problems with wordlists formatted in Windows-style line-breaks when using them on UNIX-like systems.This quick fix just removes the trailing
CRleft inlinebystd::getlineif it exists.