ci: remove redundant terraform-validate and tflint workflows#10
Open
dmchaledev wants to merge 1 commit into
Open
ci: remove redundant terraform-validate and tflint workflows#10dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
Both workflows are fully subsumed by ci.yml — same 20-module matrix, same fmt/validate/tflint checks — but use older tool versions (Terraform 1.9.5 vs 1.9.8, tflint v0.53.0 vs v0.55.0) and unpinned action refs (actions/checkout@v4 instead of the SHA-pinned form in ci.yml). Every PR was generating ~40 duplicate check statuses and burning extra runner minutes on redundant jobs. Delete both files and add .tflint.hcl to ci.yml's path triggers to preserve the intent that a lint-config change re-runs tflint. https://claude.ai/code/session_01EkHbmuzhSkPQFNreTrmN6k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terraform-validate.ymlandtflint.ymlare fully subsumed byci.yml— same 20-module matrix, same fmt / validate / tflint checks — but use older tool versions (Terraform 1.9.5 vs 1.9.8, tflint v0.53.0 vs v0.55.0) and unpinned action refs (actions/checkout@v4instead of the commit-SHA form required by ci.yml)..tflint.hclis added toci.yml'spaths:trigger to preserve the intent that a lint-config change re-runs tflint (previously handled by the deletedtflint.yml).What changed
.github/workflows/terraform-validate.ymlci.ymlfmt+validatejobs.github/workflows/tflint.ymlci.ymltflintjob.github/workflows/ci.yml.tflint.hcltoon.pull_request.pathsandon.push.pathsTest plan
ci.ymlstill triggers onmodules/**changesci.ymlnow triggers on.tflint.hclchangesterraform fmt/terraform validate/tflintentriesterraform-validate/tflint) — if they do, update the required-status-checks list to point to the equivalentci.ymljobs (terraform fmt -check,terraform validate — <module>,tflint)https://claude.ai/code/session_01EkHbmuzhSkPQFNreTrmN6k
Generated by Claude Code