docs: fix broken SARIF CLI example and inverted risk-score comment in README#16
Open
dmchaledev wants to merge 1 commit into
Open
docs: fix broken SARIF CLI example and inverted risk-score comment in README#16dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
… README The CLI accepts --format, not --output, and rejects unknown flags with exit code 2 — so the documented GitHub Code Scanning command failed on copy-paste. Also correct the programmatic score comment: higher score means more risk (100 = vulnerable, 0 = secure), matching the SecurityReport type docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two concrete, user-facing documentation bugs in the README that break on copy-paste.
1. Broken SARIF / GitHub Code Scanning example (Quick Start)
The README documents:
But the CLI accepts
--format, not--output, and explicitly rejects unknown flags with exit code 2:This is the flagship CI/CD integration command, so anyone copy-pasting it from the README hits an error. Fixed to
--format=sarif. Verified the corrected command works (exits 1 on findings as intended).2. Inverted risk-score comment (Programmatic example)
The README said:
The score is the opposite — higher = riskier. The vulnerable example config scores
100andpassed: false; the secure config scores0andpassed: true. This also matches theSecurityReport.scoretype doc ("0 (safest) – 100 (most risk)") and thecomputeScoreimplementation. Corrected to(higher = riskier).Testing
npm run build✓--output=sariffails (exit 2) and--format=sarif --exit-codeworks (exit 1 on findings) ✓vulnerable-config.json(100) andsecure-config.json(0) ✓Docs-only change; no code or behavior modified.
https://claude.ai/code/session_01MiYpVP9yynmPt1KTCiKt2d
Generated by Claude Code