Skip to content

ci: add typecheck and test gates to publish workflow#57

Open
dmchaledev wants to merge 1 commit into
mainfrom
claude/nice-mendel-Kzpk1
Open

ci: add typecheck and test gates to publish workflow#57
dmchaledev wants to merge 1 commit into
mainfrom
claude/nice-mendel-Kzpk1

Conversation

@dmchaledev
Copy link
Copy Markdown
Contributor

Problem

The publish workflow (publish.yml) skips the quality-gate steps that the CI workflow (ci.yml) always runs. This means a release can reach npm with broken types or failing tests if:

  • the tag is pushed manually (bypassing CI), or
  • workflow_dispatch is used to trigger a manual publish.

Fix

Add typecheck and test steps between dependency installation and the build, mirroring what ci.yml already does:

- name: Type-check
  run: npm run typecheck

- name: Test
  run: npm test

The job now fails fast before touching the npm registry if either check fails.

Test plan

  • Verify CI passes on this PR
  • Confirm the publish workflow job order: install → set-version → typecheck → test → build → publish

Generated by Claude Code

Ensure all quality gates pass before a package version reaches npm.
Previously the publish job only built and published, so a manually
triggered release or a tag pushed without CI could ship broken code.

https://claude.ai/code/session_01Kn3hoqSNAWaRwN4niifcAi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants