ci: add typecheck and test gates to publish workflow#57
Open
dmchaledev wants to merge 1 commit into
Open
Conversation
Ensure all quality gates pass before a package version reaches npm. Previously the publish job only built and published, so a manually triggered release or a tag pushed without CI could ship broken code. https://claude.ai/code/session_01Kn3hoqSNAWaRwN4niifcAi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish workflow (
publish.yml) skips the quality-gate steps that the CI workflow (ci.yml) always runs. This means a release can reach npm with broken types or failing tests if:workflow_dispatchis used to trigger a manual publish.Fix
Add
typecheckandteststeps between dependency installation and the build, mirroring whatci.ymlalready does:The job now fails fast before touching the npm registry if either check fails.
Test plan
Generated by Claude Code