fix: close-before-report ordering (FN-027/FN-028) + bump to v0.8.4#8
Merged
Conversation
…7/FN-028) Root cause correction for FN-023: done decided success by the gate's return code alone, but the gate can fail AFTER the task was closed and committed (late stages query 'the current active task', which no longer exists). done now decides by facts - if the task flipped to [x], the full ledger runs even on gate failure, with an explicit GATE INCONSISTENCY note. Closeout context (--next, acceptance verdicts, verify results) is snapshotted to gitignored .coderail/pending_close.json BEFORE anything mutates; progress --repair restores the real parameters from a surviving snapshot. finish_task reports 'done (WITH ERRORS)' instead of 'blocked' when the close actually happened; the rerun hint only appears for genuinely open tasks. done ends with the same audit as coderail progress as a fuse. Three end-to-end regression tests against the real flow, no mocks (76 total). Co-authored-by: v0 <it+v0agent@vercel.com>
Co-authored-by: v0 <it+v0agent@vercel.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth field-findings round, correcting the FN-023 root-cause analysis. Theme: the closeout ledger runs from a snapshot taken before anything mutates, and every verdict printed matches what actually happened on disk.
FN-027 (root cause correction)
donedecided success by the gate's return code alone, but the gate can fail AFTER the task was closed and committed.donenow decides by facts: if the task flipped to[x]in TASKS.md, the full ledger runs even on gate failure, with an explicit GATE INCONSISTENCY note. The rerun hint only appears for genuinely open tasks;finish_taskreportsdone (WITH ERRORS)instead of 'blocked' when the close actually happened. A built-in fuse runs the same audit ascoderail progressbefore declaring victory.FN-028 Closeout context (--next, acceptance verdicts, verify results) is snapshotted to gitignored
.coderail/pending_close.jsonbefore anything mutates;progress --repairrestores the real parameters from a surviving snapshot.Three end-to-end regression tests, no mocks; 76 total pass.
Co-authored-by: v0 it+v0agent@vercel.com