Add proxy config patch script#50
Open
DevSplash wants to merge 2 commits intoHaleclipse:masterfrom
Open
Conversation
Reviewer's GuideAdds a new post-build patch script that injects proxy configuration logic into Electron bootstrap files based on Codex config.toml, and wires it into the existing patch-all pipeline. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="scripts/patch-proxy-config.js" line_range="180-194" />
<code_context>
+}
+
+function patchSource(source) {
+ if (source.includes(MARKER)) {
+ const start = source.indexOf("/* " + MARKER + " */");
+ const end = source.indexOf("})();", start);
+ if (start !== -1 && end !== -1) {
+ const blockEnd = end + "})();".length;
+ const current = source.slice(start, blockEnd);
+ if (current === INJECTED) return { code: source, status: "already" };
+ return {
+ code: `${source.slice(0, start)}${INJECTED}${source.slice(blockEnd)}`,
+ status: "updated",
+ };
+ }
+ return { code: source, status: "already" };
+ }
+
</code_context>
<issue_to_address>
**suggestion:** Treat partial/failed marker matches as a mismatch instead of assuming the patch is already applied.
Because any file containing `MARKER` but lacking the exact `/* Codex proxy config patch */ ... })();` block is currently treated as `status: "already"`, truncated or manually edited blocks will be silently skipped. Consider treating the `start === -1 || end === -1` case as a mismatch (e.g., `"no-match"`) or attempting reinsertion so you avoid false positives and can log unexpected layouts.
```suggestion
function patchSource(source) {
if (source.includes(MARKER)) {
const start = source.indexOf("/* " + MARKER + " */");
const end = source.indexOf("})();", start);
// If we see the marker but can't find a well-formed injected block,
// treat this as a mismatch so callers can log/handle the anomaly.
if (start === -1 || end === -1) {
return { code: source, status: "no-match" };
}
const blockEnd = end + "})();".length;
const current = source.slice(start, blockEnd);
if (current === INJECTED) {
return { code: source, status: "already" };
}
return {
code: `${source.slice(0, start)}${INJECTED}${source.slice(blockEnd)}`,
status: "updated",
};
}
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#43
Summary by Sourcery
Add a post-build script that injects proxy configuration logic into Electron bootstrap files so the desktop app can honor Codex proxy settings from config.toml across platforms.
New Features:
Enhancements: