Conversation
change private parameters initial sequence.
src/sqlmodel.cpp
Outdated
| SqlModelPrivate::SqlModelPrivate(SqlModel *parent) | ||
| { | ||
|
|
||
| Q_UNUSED(parent); |
There was a problem hiding this comment.
The trailing ; is not necessary here.
There was a problem hiding this comment.
The trailing ; is not necessary here.
ok
There was a problem hiding this comment.
Hey guys,
I do not agree with keeping this class in the current situation. I think the structure of this class needs to change. I have concerns about this, but I don't have enough time to do it
martonmiklos
left a comment
martonmiklos
left a comment
There was a problem hiding this comment.
LGTM, btw. @HamedMasafi are you up to use the C++11 features? Like member initialisation in headers (what I would prefer because I think it results cleaner code)?
Hi @martonmiklos |
3 participants
change private parameters initial sequence.