Skip to content

chore: remove unneeded allows#272

Merged
benthecarman merged 1 commit intoHarborWallet:masterfrom
tvolk131:clippy_cleanup
Sep 8, 2025
Merged

chore: remove unneeded allows#272
benthecarman merged 1 commit intoHarborWallet:masterfrom
tvolk131:clippy_cleanup

Conversation

@tvolk131
Copy link
Contributor

@tvolk131 tvolk131 commented Sep 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 8, 2025 03:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unnecessary #[allow] attributes that suppress compiler warnings or clippy lints throughout the codebase. The changes replace manual clamping with the standard library's clamp method and remove outdated allow directives.

Key changes:

  • Replace manual min/max chaining with clamp() method in easing calculations
  • Remove #[allow(missing_debug_implementations)] attributes from struct definitions
  • Remove #[allow(clippy::too_many_arguments)] and #[allow(clippy::manual_clamp)] suppressions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
harbor-ui/src/components/spinner.rs Removes allow attribute for missing debug implementations
harbor-ui/src/components/indicator.rs Removes allow attribute for missing debug implementations
harbor-ui/src/components/easing.rs Replaces manual clamp with standard clamp method and removes clippy allow
harbor-client/src/db_models/lightning_receive.rs Removes allow attribute for too many arguments
harbor-client/src/db.rs Removes module-level allow attribute for too many arguments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@benthecarman benthecarman merged commit f786e91 into HarborWallet:master Sep 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants