Enhance signup UX by adding password length and match validation with…#202
Enhance signup UX by adding password length and match validation with…#202Heet27 wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47a563c7dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| setError("Unsupported provider."); | ||
| onSubmit(formData); |
There was a problem hiding this comment.
handleSubmit now forwards formData directly, so the agreeTerms flag is never included in the payload even after consent is validated. SignUpPage/onSignUp is typed to receive SignUpSubmitPayload with agreeTerms, so this silently breaks that contract and can lead to downstream logic receiving incomplete consent data.
Useful? React with 👍 / 👎.
| <input | ||
| placeholder="Email" | ||
| value={formData.email} | ||
| onChange={(e) => onFormChange("email", e.target.value)} | ||
| className="w-full p-3 rounded-xl bg-[#173454] text-white" |
There was a problem hiding this comment.
The email input no longer declares type="email" or required, so the browser stops enforcing basic email presence/format before submit. This allows malformed or empty email values to pass client-side and fail later in submission handling, which is a regression from the previous behavior that blocked these invalid requests immediately.
Useful? React with 👍 / 👎.
|
@Heet27 please resolve merge conflicts |
Hi, I’ve resolved the merge conflicts in |
2 participants
In this update, I focused on improving the signup form from a user experience perspective.
Previously, the form allowed users to submit passwords that were too short or did not match, which could lead to unnecessary backend errors. To fix this, I added simple client-side validation before submission.
I implemented:
I made sure not to change the existing UI layout or backend logic, so the changes are safe and only improve frontend behaviour.
This helps prevent invalid requests and gives immediate feedback to users, making the signup process smoother.
