Feature/landing hero UI#216
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0deba4442b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| setError("Unsupported provider."); | ||
| onSubmit(formData); |
There was a problem hiding this comment.
Include accepted terms in submit payload
When a user completes the checkbox validation, this now submits the raw formData instead of the SignUpSubmitPayload shape used by SignUpPage, so consumers no longer receive agreeTerms: true even though the panel has verified it. Any signup handler or audit/test path that depends on that flag will see it as missing for every successful form submission.
Useful? React with 👍 / 👎.
| className="w-full p-3 rounded-xl bg-[#173454] text-white" | ||
| /> | ||
|
|
||
| <input |
There was a problem hiding this comment.
Restore the organization name field
The signup flow still initializes and types organizationName, but the rendered form now jumps from email straight to password with no control calling onFormChange('organizationName', ...). As a result, every user registering through /signup sends the initial empty organization name even when the UI previously collected it.
Useful? React with 👍 / 👎.
| </div> | ||
|
|
||
| <p className="signup-text"> | ||
| <p className="text-center text-blue-100 mt-6 text-sm"> |
There was a problem hiding this comment.
Restore Google signup entry point
The social signup section was removed, so the signup form no longer offers the Google button that previously redirected to /v1/auth/google/authorize and is still covered by the OAuth helper/tests. Users who choose the signup page specifically to register with Google now have no way to start that OAuth flow from this screen.
Useful? React with 👍 / 👎.
liyunze-coding
left a comment
There was a problem hiding this comment.
This seems to be reversing the TailwindCSS migration change, which is counter-productive. If you had made it with TailwindCSS then I'd consider reviewing it
|
Hi Ryan, thanks for the feedback. I have now refactored the landing hero section to align more closely with the TailwindCSS migration approach by moving the UI styling into Tailwind utility classes and reducing the additional custom CSS usage. I also cleaned up the implementation and fixed the remaining formatting/linting issues in the PR. |
liyunze-coding
left a comment
There was a problem hiding this comment.
Remove LandingPage.css and use TailwindCSS
This contribution focuses on improving the landing page hero section UI and overall user experience.
The main goal was to make the landing page look more modern, visually balanced, and easier to read while keeping the existing functionality unchanged.
Changes Made
Technical Work
HeroSection.tsxResult
The landing page now feels more polished and professional while maintaining the existing AutoAudit branding and functionality. The updated hero cards are cleaner, easier to read, and provide a better first impression for users visiting the platform.