Add mobile hamburger menu with sidebar navigation and close button (X)#217
Add mobile hamburger menu with sidebar navigation and close button (X)#217JOHNNYAKUNDI-LAB wants to merge 9 commits into
Conversation
JOHNNYAKUNDI-LAB
requested review from
6igby,
du-dhartley and
liyunze-coding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9451f76b78
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| {/* Links */} | ||
| <nav className="flex flex-col gap-4 text-white mt-12"> | ||
| {navLinks.map((link) => ( | ||
| <Link key={link.label} to={link.href}> |
There was a problem hiding this comment.
When mobile users tap same-page hash links such as Home, Features, or Benefits from the landing page, this Link updates the hash without unmounting LandingHeader, and isOpen remains true. The fixed overlay/sidebar therefore continues covering the destination section until the user manually closes it.
Useful? React with 👍 / 👎.
|
Implemented mobile-responsive hamburger navigation for landing pages (Home, About, Contact).
|
|
|
liyunze-coding
left a comment
liyunze-coding
left a comment
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/position
Add sticky property to navigation bar
Updated the navigation header to use sticky positioning (sticky top-0) |
|
Just a style change to the Sign in button and it looks good to me |
Updated the mobile sidebar Sign In button styling
|
3 participants
Summary
Type of Change
Affected Components
/backend-api/frontend/engine(collectors / policies)/security/infrastructure/.github/workflows/docsMotivation
This change was required to improve usability on mobile devices and ensure consistency with the existing dashboard navigation pattern.
Testing Done
Tested in browser using developer tools (responsive mode):
Verified hamburger menu appears on mobile view only
Confirmed sidebar opens on click and closes via overlay and close (X) button
Checked navigation links function correctly
Verified desktop view remains unchanged
Security Considerations
This change does not introduce any security risks. It is limited to frontend UI behaviour and does not affect authentication, API access, or data handling.
Breaking Changes
Rollback Plan
Checklist
Screenshots