Improve auth pages with TailwindCSS responsive layout#225
Conversation
srujan0301
requested review from
6igby,
du-dhartley and
liyunze-coding
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99fdb8adc4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,27 +1,39 @@ | |||
| import React from "react"; | |||
| import "./LoginPage.css"; | |||
| import "../Landing/LandingPage.css"; | |||
There was a problem hiding this comment.
This change removes LoginPage.css from the auth pages, but the rendered child components still rely on legacy class names such as auth-header, login-brand, login-form-card, and btn-signin (and signup-specific classes are similarly tied to SignUpPage.css). I checked the repo with rg and there are no remaining imports of these stylesheets, so /login, /signup, and the Google callback screen will load without the CSS rules those components depend on, causing a major layout/styling regression for auth flows.
Useful? React with 👍 / 👎.
liyunze-coding
left a comment
liyunze-coding
left a comment
There was a problem hiding this comment.
Please resolve merge conflicts, by merging or rebasing with main
|
Resolved merge conflicts, restored required stylesheet imports, cleaned merge markers, and fixed lint issues. All CI checks are now passing. |
| @@ -1,33 +1,32 @@ | |||
| import React from "react"; | |||
| import "../Landing/LandingPage.css"; | |||
| import "./LoginPage.css"; | |||
There was a problem hiding this comment.
There is no LandingPage.css nor LoginPage.css
| import SignupFormPanel from "./components/SignupFormPanel"; | ||
| import type { SignUpFormData, SignUpSubmitPayload } from "./signUpTypes"; | ||
| import "./LoginPage.css"; | ||
| import "./SignUpPage.css"; |
There was a problem hiding this comment.
Remove CSS files, are you sure you tested locally before push?
|
Resolved the requested review changes by removing invalid stylesheet imports, fixing merge conflicts, and cleaning auth page updates. All CI and lint checks are now passing successfully. |
|
@liyunze-coding requested re-review after changes |
3 participants
Improved authentication pages using TailwindCSS responsive utility classes. Reduced dependency on older layout-based CSS styling and updated LoginPage, SignUpPage, and GoogleCallbackPage layouts. Improved responsiveness, spacing, alignment, and frontend UI consistency while preserving existing authentication functionality and routing behavior.
This change focuses on frontend UI improvement and refactoring by modernizing layout styling using TailwindCSS utilities. The goal was to improve responsiveness, reduce duplicated layout CSS, and make the authentication pages easier to maintain.
Manual testing was completed for:
Production build was successfully verified using
npm run build.No security-sensitive logic was modified and no breaking changes were introduced. Reverting the commit would be sufficient if rollback is required.