Fix base64 output for linkedin icons and sed regex#1
Open
alexbraga wants to merge 1 commit intoHariSekhon:mainfrom
Open
Fix base64 output for linkedin icons and sed regex#1alexbraga wants to merge 1 commit intoHariSekhon:mainfrom
sed regex#1alexbraga wants to merge 1 commit intoHariSekhon:mainfrom
Conversation
|
booger-bit
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base64 outputs for both LinkedIn icons (dim and white) in the 'Removed Icons' section of the
markdown.mdfile didn't match the correct values. Also, the regex for thesedcommand to add the SVG attributefill="#ffffff"didn't include the necessary whitespace at the beginning of the replacement string. Another small fix was to add the 'global' flag to the regex, to handle logos with multiple paths, like the Java one.