Document new read_log filter param #425
Conversation
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
Is this being released in v4.7 (or any other v4 versions?), if so please copy to versioned docs too.
|
FYI - there is a broken commit on main right now breaking the build; I'll have it fixed soon. |
|
Can you rebase? I fixed |
cap10morgan
force-pushed
the
add/read_log-filtering
branch
from
6edd9f3 to
90a6c42
Compare
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-425 This preview will update automatically when you push new commits. |
Done in e79234f. Generally I like to get feedback on the change first, and then copy it to the correct version(s) after folks approve of the change itself. But I certainly don't mind hearing where others expect to see it show up before merging either, so all good 👍🏻. |
Looks like that fixed it, thanks! |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-docs.stage.harperfabric.com/pr-425 This preview will update automatically when you push new commits. |
|
Yeah me too! I think including in a PR body that you intend to receive feedback first and then will copy to other versions would be beneficial. Anyways, me saying that in a review is also generally an implicit approval that the content so far is good enough! |
Added in https://github.com/HarperFast/harperdb/pull/3044