Fix: protect static cache in RaceDataManager with lock#21
Open
HashidaTKS wants to merge 1 commit into
Open
Conversation
…ace conditions CachedHoldingInformation is a static field accessed from both the UI thread and background Task.Run threads without synchronization, creating a data race. Add a dedicated static lock object (_cacheLock) and mark the field volatile so that reads and writes to the cache are properly serialized across threads. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
RaceDataManager.CachedHoldingInformationは静的フィールドだが、UIスレッドとバックグラウンドのTask.Run()から同時にアクセス・更新される可能性があり、lockもvolatileもなかった。これにより複数スレッドが同時にキャッシュを参照・更新した場合に競合状態（race condition）が発生し、古いキャッシュを参照し続けたり、読み書きが中途半端な状態のオブジェクトを参照するリスクがあった。
改善内容
private static readonly object _cacheLockを追加CachedHoldingInformationの読み書きをすべてlock (_cacheLock)で保護CachedHoldingInformationにvolatileを追加してキャッシュの可視性を保証ResetCache()も同じロックで保護Test plan
GetRaceDataOfDayを呼び出してもデータ競合が発生しないことを確認ResetCache()がスレッドセーフに機能することを確認🤖 Generated with Claude Code