Fix: remove redundant lock(this) in ReadFromDateAndRegion#23
Open
HashidaTKS wants to merge 1 commit into
Open
Conversation
ReadAll() already acquires lock(this) internally in BaseRepository, making the outer lock(this) in ReadFromDateAndRegion a redundant reentrant lock. C# lock is reentrant so it doesn't deadlock, but the duplicate locking is misleading and suggests the locking strategy is misunderstood. Remove the outer lock as ReadAll() handles synchronization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
HoldingInformationRepository.ReadFromDateAndRegion()で外側にlock(this)を設定しているが、内部で呼ぶReadAll()もBaseRepository内でlock(this)を持つ。C# の lock はリエントラントなのでデッドロックは発生しないが、二重ロックは設計の意図が不明瞭で、将来の変更者に混乱を与える。
改善内容
ReadFromDateAndRegionの外側のlock(this)を削除ReadAll()の内部ロックで排他制御が担保されるTest plan
ReadFromDateAndRegionが正しい結果を返すことを確認🤖 Generated with Claude Code