Fix: replace per-iteration OrderBy with HashSet.SetEquals in GetPayBack#34
Open
HashidaTKS wants to merge 1 commit into
Open
Fix: replace per-iteration OrderBy with HashSet.SetEquals in GetPayBack#34HashidaTKS wants to merge 1 commit into
HashidaTKS wants to merge 1 commit into
Conversation
The comment said to avoid OrderBy inside the loop, but result.Item1.OrderBy() was still called on every iteration. Replace the sorted-sequence comparison with HashSet.SetEquals, which is order-independent and O(n) rather than O(n log n) per iteration, eliminating both the correctness inconsistency and the redundant sort. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
Simulator.GetPayBack()で「ループ内で毎回 OrderBy するのを避け」というコメントがあったが、result.Item1.OrderBy(_ => _)はループ内に残っており、コメントと実装が矛盾していた（line 261）。結果として毎イテレーションで O(n log n) のソートが実行され続けていた。
改善内容
BetDatum.HorseNumListをHashSet<int>に変換（ループ前に一度だけ）result.Item1.OrderBy().SequenceEqual()をbetHorsesSet.SetEquals(result.Item1)に置き換えTest plan
🤖 Generated with Claude Code