Show getResourceKey on large instances; drop analytics skeleton#81
Merged
Panthevm merged 2 commits intoMay 19, 2026
Merged
Conversation
… fix Submodule bump on aidbox-ts-sdk: paginate StructureDefinition search with _count=1000 (HealthSamurai/aidbox-ts-sdk#125). Without it, large Aidbox instances (>100 StructureDefinitions) drop Patient/Resource from getResourceTypes(), and FHIRPath completion stops suggesting getResourceKey/getReferenceKey. Switch the npm dep to file:aidbox-ts-sdk/packages/aidbox-fhirpath-lsp so the fix is consumed without waiting for an npm release; add a pnpm.overrides for @health-samurai/aidbox-client so the submodule's workspace:^ link resolves, and build the LSP package in preinstall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aidbox-ts-sdkto pick upaidbox-fhirpath-lspsearch pagination fix (fhirpath-lsp: paginate StructureDefinition search with _count=1000 aidbox-ts-sdk#125). On production-sized boxes (>100StructureDefinitions),/fhir/StructureDefinition?kind=resourcereturns only the first 100 entries with nolink.next, so the LSP'sgetResourceTypes()did not see e.g.Patient/Resource. As a result FHIRPath completion hidgetResourceKey/getReferenceKeyin the ViewDefinition Builder.file:aidbox-ts-sdk/packages/aidbox-fhirpath-lspso the fix ships now without waiting for an npm release; build the package inpreinstall; add a pnpm override for@health-samurai/aidbox-clientso the submodule'sworkspace:^link resolves locally.Skeletonplaceholder on/analytics,/analytics/queries,/analytics/views. The recents list now renders empty/data directly without a flicker.Test plan
StructureDefinitionresources, open/u/analytics/views/create→ typegetin a COLUMN path;getResourceKeyandgetReferenceKeyshould appear./u/analytics,/u/analytics/queries,/u/analytics/views; no skeleton placeholder is shown during the initial load.pnpm installfrom a clean checkout succeeds (preinstall builds aidbox-client, react-components, and aidbox-fhirpath-lsp).make build-aidbox-uiinsansara/boxproduces a working bundle.Dependencies
development.