[sansara#7679] Use generateId() instead of direct crypto.randomUUID()#83
Merged
Conversation
Two call sites used crypto.randomUUID() directly, which throws TypeError in non-secure contexts (plain HTTP, not localhost): - src/routes/rest.tsx:366 (REST console upsertHeader) - src/components/DataLineage/sidebar.tsx:60 (DataLineage SkeletonRows) The safe generateId() wrapper in utils.ts falls back to a Math.random based UUIDv4 string when crypto.randomUUID is unavailable. Closes HealthSamurai/sansara#7679
Panthevm
force-pushed
the
fix/rest-upsert-header-randomuuid
branch
2 times, most recently
from
7614f94 to
00d0487
Compare
Panthevm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two call sites used `crypto.randomUUID()` directly, which throws `TypeError: crypto.randomUUID is not a function` in non-secure contexts (plain HTTP, not localhost):
Both are switched to the existing safe `generateId()` wrapper in `utils.ts`, which falls back to a `Math.random`-based UUIDv4 string when `crypto.randomUUID` is unavailable.
REST regression originally introduced by `57aa46ab` ("Reduce cognitive complexity across 8 files"), which re-introduced the direct call after `ab16111` had already removed all such usages.
Test plan
Closes HealthSamurai/sansara#7679.