Navbar: fix New UI switch crash in Firefox/Safari#84
Merged
Conversation
cookieStore is a Chromium-only experimental API, so toggling the "New UI" switch threw a ReferenceError in non-Chromium browsers. Add a setCookie helper that uses cookieStore when available and falls back to document.cookie everywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cookieStoreis a Chromium-only experimental API; toggling the "New UI" switch threwUncaught ReferenceError: cookieStore is not definedin Firefox and Safari.setCookiehelper insrc/utils/cookie.tsthat usescookieStorewhen available and falls back todocument.cookieeverywhere else.src/layout/navbar.tsxinstead of callingcookieStore.setdirectly.Test plan
aidbox-preferred-ui=oldis set, page redirects to legacy UI.ReferenceErrorin console, cookie is set, redirect happens.