Fix for Final Boards lingering by using dispatch queue#1362
Open
nheagy wants to merge 2 commits intoHearthSim:masterfrom
Open
Fix for Final Boards lingering by using dispatch queue#1362nheagy wants to merge 2 commits intoHearthSim:masterfrom
nheagy wants to merge 2 commits intoHearthSim:masterfrom
Conversation
azeier
force-pushed
the
master
branch
14 times, most recently
from
d653ee6 to
aa3f672
Compare
azeier
force-pushed
the
master
branch
7 times, most recently
from
15ecafb to
5ee0b4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working from the theory that the bug is caused because the mouseExisted event fires before the mouseEntered event has displayed the panel, this patch ensures that Final Boards dismiss by putting their creation inside a
DispatchWorkItemthat is then cancelled in the exit method.We can still speed up creation of the final board panel in a few ways - one being building for arm64 on Apple Silicon - but the race condition would still remain without this PR.