Refined some basic concepts of the crate

[alexpyattaev]

Hi! I've started checking the code for memory soundness around the Box::leak idea you've used, and, as one would expect, it was leaking memory. So I ended up changing quite a bit of logic around the idea of how Text gets formatted and escaped to avoid memory leaks without breaking the convenience of using &str for chunks of the regex being built. I think the current version is far better in terms of its internal logic and it avoids making RE engine to escape things in the Text portions of the regex. But then I got carried away and changed other things as well... Hope you like them!

Another change is around Exactly, it was kind of misnamed, as it was matching whole words, not whole lines. Furthermore, the pattern of using Exactly(Word) was silly, so I moved things around a bit to make it possible to write something like

Times(Digit, 4).grouped_as("year")
.and(Text("-"))
.and(Times(Digit, 2).grouped_as("month"))
.and(Text(("-")))
.and(Times(Digit, 2).grouped_as("day"));

which feels far less cluttered then the original version with Exactly wrapping every Text tag.

Finally, I've moved grouping into its own trait and implemented it for Type as well as Input objects. This makes it possible to define groups over things like single Digit objects, which is quite nice to use.

Overall, I hope you like these changes, looking forward for your feedback.

[Heiss]

A wow! Thanks for your contribution. I will need some time to go through your changes.

[alexpyattaev]

You are welcome! Hope you will find a way around the NotText issue, I could not make it do useful things. 1.6.2024 15.34.00 Peter Heiss ***@***.***>:

…

A wow! Thanks for your contribution. I will need some time to go through your changes. — Reply to this email directly, view it on GitHub[#2 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABNIL3V4EJS6QBXNQHINCZ3ZFG5TRAVCNFSM6AAAAABITSBJSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGQZTGMJTGQ]. You are receiving this because you authored the thread. [Seurantakuva][https://github.com/notifications/beacon/ABNIL3WG5KURWFK77Z2IIS3ZFG5TRA5CNFSM6AAAAABITSBJSSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT7YIY24.gif]