feat: add ESLint, Prettier, pin bun, and gate CI on lint + format#167
Merged
Conversation
Closes Heliobond#31 — ESLint with next/core-web-vitals and TypeScript rules Closes Heliobond#32 — Prettier (semi:false, singleQuote, trailingComma:all, printWidth:100) Closes Heliobond#33 — CI gates on lint and format:check after build/typecheck Closes Heliobond#34 — Pin bun to 1.2.4 in CI; record version in CONTRIBUTING.md New files: - eslint.config.mjs — flat-config extending next/core-web-vitals + next/typescript - .prettierrc — matches existing code style - .prettierignore — excludes .next, public, lock files package.json: adds lint, format, format:check scripts and four new devDeps (@eslint/eslintrc, eslint, eslint-config-next, prettier) ESLint violations resolved: - Unused vars removed (AmountInput.test.tsx, WalletProvider.test.ts, creator/page.tsx) - react-hooks/set-state-in-effect suppressed with eslint-disable-next-line where the pattern is intentional (hydration guard, localStorage restore, capability probe) - react-hooks/refs suppressed for the itemRefs reset-before-render pattern in TopBar Prettier ran --write across all src/, e2e/, and root config files. Note: bun.lock was not regenerated (bun unavailable locally). CI uses `bun install` (without --frozen-lockfile) so bun resolves new packages on first run. Please commit the updated bun.lock after this PR merges.
|
@devjayy43 is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Jayy4rl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
OracleForms.test.tsx had apy/category/description/risk (not on RegistryEntry) and was missing the required `type` field from Project. RegistryTable.test.tsx had description/irr/tenor/sharePrice/poolShare/tags/ highlights/currency — none are in Project or RegistryEntry, and none were used by the test assertions. Stripping the extraneous fields fixes the four TS2353 errors that broke `bun run typecheck` in CI.
next lint in Next.js 16 treats the subcommand name as a directory path, producing "Invalid project directory provided, no such directory: .../lint". Using eslint . directly is equivalent and avoids the CLI parsing bug. Also name the default export in eslint.config.mjs to silence the import/no-anonymous-default-export warning.
Initial run only targeted src/**/*.{ts,tsx} and root configs.
CSS, markdown, YAML, and JSON files were missed. Running
prettier --write . covers all 21 previously unformatted files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31 — ESLint with next/core-web-vitals and TypeScript rules Closes #32 — Prettier (semi:false, singleQuote, trailingComma:all, printWidth:100) Closes #33 — CI gates on lint and format:check after build/typecheck Closes #34 — Pin bun to 1.2.4 in CI; record version in CONTRIBUTING.md
New files:
package.json: adds lint, format, format:check scripts and four new devDeps
(@eslint/eslintrc, eslint, eslint-config-next, prettier)
ESLint violations resolved:
Prettier ran --write across all src/, e2e/, and root config files.
Note: bun.lock was not regenerated (bun unavailable locally). CI uses
bun install(without --frozen-lockfile) so bun resolves new packages on first run. Please commit the updated bun.lock after this PR merges.Summary
Linked issue
Closes #
Type of change
Screenshots / screencast
Checklist
Closes #…)bun run buildpasses locally (builds + type-checks)messages/en.jsonandmessages/fr.json(if any copy changed)