Resolve assigned issues: CI cache, .nvmrc, lint-staged, i18n ProjectDetail#168
Merged
Merged
Conversation
- Heliobond#36: Add engines.node >=18.18.0 and .nvmrc - Heliobond#38: Add husky + lint-staged pre-commit hook - Heliobond#49: Internationalize ProjectDetail screen, add en/fr translations Closes Heliobond#36 Closes Heliobond#38 Closes Heliobond#49
|
@Smartdevs17 is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Smartdevs17 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#35 - Cache Next.js build cache in CI
Cache
.next/cachebetween CI runs keyed onbun.lockto speed up repeat builds.#36 - Add engines field and .nvmrc
Add
engines.node >=18.18.0topackage.jsonand matching.nvmrc.#38 - Add lint-staged pre-commit hook
Add husky + lint-staged running
tsc --noEmiton staged TypeScript files. Documented as optional in CONTRIBUTING.md.#49 - Internationalize ProjectDetail screen
Replace all hardcoded English strings with
useTranslations('ProjectDetail')calls. Add en/fr translations.Closes #35
Closes #36
Closes #38
Closes #49