Fix/core matid preservation#3
Open
HellAngel18 wants to merge 2 commits into
Open
Conversation
- CMakeLists: add binary dir include path and link VCGSimplifier for CLI target - SaveGLB: keep images in BIN chunk instead of Base64 data URI encoding - main: recover material IDs after simplification via nearest-centroid matching - Fixes issue where simplified GLB lost all textures (all faces mapped to mat 0) and output file was larger than input due to Base64 image bloat Made-with: Cursor
- Add nearest-centroid matId recovery in SimplifyDetailed() so all callers (CLI, DLL API, engine plugins) benefit from material preservation - Remove CLI-only workaround from main.cpp - matId is now saved before simplification and restored after via centroid matching, compensating for VCG QEM not propagating custom face attributes Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.