feat(TP-192): code-quality lint cleanup — Biome lint exits 0 on main#571
Merged
Conversation
…trolCharactersInRegex x1, noRedeclare x2, noUnsafeFinally x1)
- noImplicitAnyLet: annotate let variables in regex-exec loops
(lane-runner.ts, task-executor-core.ts x3) and readdirSync result
(merge.ts; added Dirent type import)
- noControlCharactersInRegex: convert verification.ts ANSI_REGEX literal
to new RegExp(escaped string, 'g'); drop stale eslint disable comment
- noRedeclare: remove non-existent AllocateLanesResult type-import in
waves.ts (canonical declaration is local); rename duplicate
resolveRepoRoot in orch-state-persistence.test.ts (section 8.1) to
resolveRepoRootMixedRepo (14 callers updated)
- noUnsafeFinally: invert if(!snapshot) return; to if(snapshot){...} in
extension.ts withPreservedBatchHistory finally block
npm run lint now exits 0 (was: 9 errors). Tests: 3624/1/0 unchanged
from baseline. No suppressions added; behavior preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of five sequenced packets implementing the code-quality-gates spec. Fixes the 9 existing Biome errors so TP-194's gate flip can promote lint to a hard gate without breaking the build.
What ships
npm run lintnow exits 0 on this branch (was: exit 1 with 9 errors).Errors fixed
Per the inventory captured during TP-191:
noRedeclareAllocateLanesResult,resolveRepoRootinextension.ts)noImplicitAnyLetnoControlCharactersInRegexnoUnsafeFinallyAll fixes are surface-level mechanical changes — no behavior changes, no refactors beyond what each rule specifically requires. Per the PROMPT's anti-shortcut policy: no
// biome-ignoresuppressions, every error fixed properly.What this does NOT do (per spec scope boundaries)
biome format --write(TP-193's job)continue-on-error: truefrom CI (TP-194's job)Validation