Skip to content

fix(android): redact sensitive runtime logs#27

Closed
AmirrezaFarnamTaheri wants to merge 1 commit into
Hidden-Node:mainfrom
AmirrezaFarnamTaheri:android-log-redaction
Closed

fix(android): redact sensitive runtime logs#27
AmirrezaFarnamTaheri wants to merge 1 commit into
Hidden-Node:mainfrom
AmirrezaFarnamTaheri:android-log-redaction

Conversation

@AmirrezaFarnamTaheri
Copy link
Copy Markdown
Contributor

Summary

  • add a shared SecretRedactor for UI/runtime log lines
  • redact encryption keys, SOCKS/proxy credentials, profile links, tokens, and app-private paths
  • apply redaction at the VpnManager log ingestion boundary so shared logs stay safer

Validation

  • git diff --check upstream/main..android-log-redaction
  • gradle :app:compileDebugKotlin reaches Kotlin compilation but is blocked by the existing missing gomobile/mobile package AAR setup, not by the redaction changes.

@Hidden-Node
Copy link
Copy Markdown
Owner

Thank you for your hard work on this implementation. While I appreciate the focus on privacy and security, I’ve decided not to merge this PR at this time for the following reasons:

Maintainability & Core Alignment: The log structure within the client core is subject to change. Relying on regex-based redaction on the Android side might become fragile or lead to broken logs if the core output format evolves in future releases.
User Experience (UX): I am concerned that redacting sensitive-looking fields might confuse beginner users. Seeing masked values could lead them to believe there is a misconfiguration or an error in their setup, increasing support requests.
I believe that for now, keeping the raw logs as they are is better for transparency and debugging purposes. I might reconsider adding this feature or a similar implementation in the future as the project matures.

Thanks again for your contribution and for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants