You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gradle :app:compileDebugKotlin reaches Kotlin compilation but is blocked by the existing missing gomobile/mobile package AAR setup, not by the redaction changes.
Thank you for your hard work on this implementation. While I appreciate the focus on privacy and security, I’ve decided not to merge this PR at this time for the following reasons:
Maintainability & Core Alignment: The log structure within the client core is subject to change. Relying on regex-based redaction on the Android side might become fragile or lead to broken logs if the core output format evolves in future releases.
User Experience (UX): I am concerned that redacting sensitive-looking fields might confuse beginner users. Seeing masked values could lead them to believe there is a misconfiguration or an error in their setup, increasing support requests.
I believe that for now, keeping the raw logs as they are is better for transparency and debugging purposes. I might reconsider adding this feature or a similar implementation in the future as the project matures.
Thanks again for your contribution and for your understanding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check upstream/main..android-log-redactiongradle :app:compileDebugKotlinreaches Kotlin compilation but is blocked by the existing missing gomobile/mobile package AAR setup, not by the redaction changes.