fix(android): limit imported profile payloads#30
Closed
AmirrezaFarnamTaheri wants to merge 1 commit into
Closed
Conversation
Owner
|
Thank you for the effort in implementing these payload limits. However, I’ve decided not to merge this PR at this time. The main reason is that some advanced users may want to import and scan very large lists of DNS resolvers. Setting a strict 256 KB limit could prevent them from importing comprehensive lists for scanning, which is a key feature of the app. While I agree that stability is important, I believe that for this specific project, the flexibility of importing large datasets outweighs the risks of memory exhaustion from malformed files. I’ll keep the idea of payload limits in mind for future optimizations, perhaps with a much higher ceiling or a different approach to handling large files. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkgradle :app:compileDebugKotlinreaches Kotlin compilation but is blocked by the existing missing gomobilemobilepackage/AAR setup.