fix(auth): demo cookie cleanup in middleware#92
Closed
NicholaiVogel wants to merge 3 commits intomainfrom
Closed
Conversation
Add org-scoped data isolation across all server actions to prevent cross-org data leakage. Add read-only demo mode with mutation guards on all write endpoints. Multi-tenancy: - org filter on executeDashboardQueries (all query types) - org boundary checks on getChannel, joinChannel - searchMentionableUsers derives org from session - getConversationUsage scoped to user, not org-wide for admins - organizations table, members, org switcher component Demo mode: - /demo route sets strict sameSite cookie - isDemoUser guards on all mutation server actions - demo banner, CTA dialog, and gate components - seed script for demo org data Also: exclude scripts/ from tsconfig (fixes build), add multi-tenancy architecture documentation.
The demo cookie was checked unconditionally before WorkOS auth, so logging in with real credentials after visiting /demo still returned the demo user. Now getCurrentUser() tries WorkOS first and only falls back to the demo cookie when no real session exists. Clears the stale cookie on real login.
The previous fix reordered getCurrentUser() to prefer WorkOS sessions, but cookie deletion silently failed because it ran from a Server Component (cookies().delete() only works in Server Actions and Route Handlers). Move demo cookie cleanup to middleware where response cookies work. Real sessions now actively delete the stale demo cookie. Demo route also clears compass-active-org so demo mode doesn't inherit a real user's workspace selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCurrentUser()(Server Component, wherecookies().delete()silently fails) to middleware where response cookies actually workSet-Cookieon the response/demoroute clearscompass-active-orgso demo mode doesn't inherit a real user's workspaceContext
PR #91 reordered
getCurrentUser()to check WorkOS before the demo cookie -- correct priority, but the cookie deletion was a no-op from Server Component context. This meant the demo cookie persisted for its full 24h lifetime, causing the middleware to short-circuit auth checks on every request even when a real session existed.Test plan
/demo-- lands in demo org (Meridian Group), not previous real orgcompass-democookie absent after real login via browser devtools