fix(auth): demo cookie cleanup in middleware#93
Merged
NicholaiVogel merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
The demo cookie deletion in getCurrentUser() was a no-op from Server Component context (cookies().delete() only works in Server Actions and Route Handlers). The cookie persisted for its full 24h lifetime, causing middleware to short-circuit auth checks even when a real WorkOS session existed. - Middleware: real session now takes priority over demo cookie, stale cookie actively deleted via Set-Cookie on response - auth.ts: remove early demo-first check and dead deletion code, WorkOS session checked before demo fallback - /demo route: clear compass-active-org so demo doesn't inherit a real user's workspace selection
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
compass | 05f6cc1 | Feb 16 2026, 05:46 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCurrentUser()(Server Component, wherecookies().delete()silently fails) to middleware where response cookies actually workSet-Cookieon the responsegetCurrentUser()/demoroute clearscompass-active-orgso demo mode doesn't inherit a real user's workspaceContext
The demo cookie deletion in
getCurrentUser()was a no-op from Server Component context --cookies().delete()only works in Server Actions and Route Handlers. The cookie persisted for its full 24h lifetime, and middleware short-circuited auth checks even when a real WorkOS session existed.Test plan
/demo-- lands in demo org (Meridian Group), not previous real orgcompass-democookie absent after real login via browser devtools