🧹 [Code Health] Extract magic number for bio length into a constant#337
🧹 [Code Health] Extract magic number for bio length into a constant#337is0692vs wants to merge 4 commits into
Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
More reviews will be available in 37 minutes and 21 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors src/lib/cardElements.tsx by extracting the magic number 110 into a constant MAX_BIO_LENGTH. A review comment suggests using Array.from() when slicing the bio string to prevent splitting surrogate pairs (such as emojis) and causing rendering issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| {data.profile.bio.length > MAX_BIO_LENGTH | ||
| ? `${data.profile.bio.slice(0, MAX_BIO_LENGTH)}...` | ||
| : data.profile.bio} |
There was a problem hiding this comment.
Truncating the bio string using standard String.prototype.slice can split surrogate pairs (such as emojis or certain multi-byte characters) if the truncation point falls in the middle of one. This can result in rendering malformed characters in the UI.
Using Array.from() or the spread operator ([...]) ensures that the string is sliced by Unicode code points rather than UTF-16 code units, preserving emojis and other multi-byte characters correctly.
| {data.profile.bio.length > MAX_BIO_LENGTH | |
| ? `${data.profile.bio.slice(0, MAX_BIO_LENGTH)}...` | |
| : data.profile.bio} | |
| {data.profile.bio.length > MAX_BIO_LENGTH | |
| ? Array.from(data.profile.bio).slice(0, MAX_BIO_LENGTH).join("") + "..." | |
| : data.profile.bio} |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
1 participant
🎯 What: The hardcoded magic number
110used for truncating the bio length insrc/lib/cardElements.tsxhas been extracted into a top-level constantMAX_BIO_LENGTH.💡 Why: By extracting this hardcoded number into a well-named constant, it improves the maintainability and readability of the codebase. It clearly defines the intent of the number and makes it easier to update the bio length limit consistently across the file in the future.
✅ Verification:
npm run lint) passed.npm run test) successfully passed.src/lib/cardElements.tsx(src/lib/__tests__/cardElements.test.tsx) was run and passed.✨ Result: The code health issue is resolved without changing the underlying functionality, resulting in a cleaner and more maintainable code structure.
PR created automatically by Jules for task 12727248390082554642 started by @is0692vs
Greptile Summary
バイオの文字数制限として使用されていたマジックナンバー
110を、MAX_BIO_LENGTHという名前付き定数に抽出するリファクタリングです。機能的な変更は一切ありません。src/lib/cardElements.tsxのファイル先頭にconst MAX_BIO_LENGTH = 110;を追加し、createBioBlock関数内の2箇所のハードコードされた110を置き換えました。Confidence Score: 5/5
変更はマジックナンバーの抽出のみで、ロジックに一切手を加えていないため、安全にマージできます。
変更箇所は MAX_BIO_LENGTH 定数の導入と、それを参照する2行への置き換えのみです。比較条件とスライスの両方に同じ定数が使われており、リファクタリング前後で動作は完全に同一です。
特に注意が必要なファイルはありません。
Important Files Changed
110を定数MAX_BIO_LENGTHに抽出。機能的な変更はなし。Reviews (1): Last reviewed commit: "refactor: extract magic number 110 into ..." | Re-trigger Greptile