🧹 Extract magic number for bio length truncation to constant#339
🧹 Extract magic number for bio length truncation to constant#339is0692vs wants to merge 1 commit into
Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
More reviews will be available in 57 minutes and 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a named constant MAX_BIO_LENGTH with a value of 120 to replace a hardcoded magic number in the OG image generation route. This improves code readability and maintainability. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const ONE_HOUR_IN_SECONDS = 60 * 60; | ||
| const ONE_DAY_IN_SECONDS = 24 * ONE_HOUR_IN_SECONDS; | ||
| const OG_CACHE_CONTROL = `public, max-age=${ONE_HOUR_IN_SECONDS}, s-maxage=${ONE_DAY_IN_SECONDS}, stale-while-revalidate=${ONE_DAY_IN_SECONDS}`; | ||
| const MAX_BIO_LENGTH = 120; |
There was a problem hiding this comment.
MAX_BIO_LENGTH がテストファイル（route.test.ts）ではまだハードコードの 120 として残っています（81行目のテスト説明と93行目の期待値）。定数をエクスポートすることでテスト側からも参照でき、将来値を変更する際の変更漏れを防げます。
| const MAX_BIO_LENGTH = 120; | |
| export const MAX_BIO_LENGTH = 120; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/app/api/og/[username]/route.tsx
Line: 14
Comment:
`MAX_BIO_LENGTH` がテストファイル（`route.test.ts`）ではまだハードコードの `120` として残っています（81行目のテスト説明と93行目の期待値）。定数をエクスポートすることでテスト側からも参照でき、将来値を変更する際の変更漏れを防げます。
```suggestion
export const MAX_BIO_LENGTH = 120;
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
🎯 What: The magic number
120used for truncating user bios insrc/app/api/og/[username]/route.tsxwas extracted into a top-level constantMAX_BIO_LENGTH.💡 Why: Magic numbers make code harder to read and maintain. Centralizing this value at the top of the file alongside other configuration constants ensures that any future changes to the bio length limit only need to be updated in one clear location, preventing accidental mismatches between the condition (
length > 120) and the action (slice(0, 120)).✅ Verification: Ran
npm run lintandnpm run testto confirm there are no formatting issues or regressions. The visual logic and behavior remain strictly identical.✨ Result: A more readable, declarative, and maintainable OG image generation route.
PR created automatically by Jules for task 3486996076403614057 started by @is0692vs
Greptile Summary
バイオのトランケート処理で使われていたマジックナンバー
120をMAX_BIO_LENGTH定数へ切り出すシンプルなリファクタリングです。ロジックの変更はなく、視覚的な出力も完全に同一です。MAX_BIO_LENGTH = 120を他の設定定数（ONE_HOUR_IN_SECONDS等）と同じ場所に追加し、条件式とsliceの両方で参照するよう変更。route.test.ts）側ではまだ120がハードコードされており、定数をエクスポートすることで参照可能になる。Confidence Score: 5/5
動作の変更を含まない純粋なリファクタリングで、マージしても安全です。
変更箇所は定数の導入と2箇所の参照置き換えのみで、条件式と
sliceの両方が同じ定数を使っており整合性も取れています。テストファイルにまだハードコードの120が残っていますが、テスト自体は現在も正しく動作しています。特に注意が必要なファイルはありません。
route.test.tsのハードコード値は定数をエクスポートすることで解消できます。Important Files Changed
120をMAX_BIO_LENGTH定数に切り出すリファクタリング。条件とsliceの両方が正しく更新されており、既存の動作に変更はない。Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[bio 文字列を取得] --> B{bio.length > MAX_BIO_LENGTH?} B -- Yes --> C["bio.slice(0, MAX_BIO_LENGTH) + '…'"] B -- No --> D[bio をそのまま表示] C --> E[OG画像に描画] D --> EPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "🧹 Extract magic number for bio length t..." | Re-trigger Greptile